refactor: move visitor creation to before/after blocks in livechat room tests by Copilot · Pull Request #39289 · RocketChat/Rocket.Chat

Copilot · 2026-03-03T14:00:54Z

Restructure describe('livechat/room') into two sub-blocks
Create shared before/after hooks for visitor lifecycle
Add roomsToClose Set mechanism to collect room IDs for cleanup
Move roomsToClose.add() calls before expect statements to ensure cleanup happens even if assertions fail
Remove room IDs from the set after successfully closing them
Remove TODO comments requesting this refactoring

Original prompt

This section details on the original issue you should resolve

<issue_title>this visitor should be created on before block and deleted on after block</issue_title>
<issue_description>

📝 Found in apps/meteor/tests/end-to-end/api/livechat/00-rooms.ts#L156

Commit: d9bceb4</issue_description>

Comments on the Issue (you are @copilot in this section)

Custom agent used: Refactor Agent
A disciplined agent that performs code refactoring with a focus on improving code quality,
maintainability, and readability without changing external behavior. It ensures all tests
pass before and after changes, and creates incremental, reviewable PRs.

Fixes this visitor should be created on before block and deleted on after block #39285

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

dionisio-bot · 2026-03-03T14:00:58Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is targeting the wrong base branch. It should target 8.5.0, but it targets 8.4.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

changeset-bot · 2026-03-03T14:01:00Z

⚠️ No Changeset found

Latest commit: e4abb2f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

…om tests Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>

…solation Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>

ggazzo

@copilot you can share the same before/after among the ones that makes sense

…block Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>

Copilot · 2026-03-03T14:13:03Z

@copilot you can share the same before/after among the ones that makes sense

Done in 9881835. Consolidated all tests using a standard visitor into a single describe('with a valid visitor') block with shared before/after hooks. The EE-only test remains separate since it requires a visitor with a special name.

ggazzo

Could you create a mechanism that adds the rooms to an array and then removes them in the after event, to prevent the room removal process from failing?

Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>

Copilot · 2026-03-03T14:25:13Z

Could you create a mechanism that adds the rooms to an array and then removes them in the after event, to prevent the room removal process from failing?

Done in 7a88808. Added a roomsToClose Set that collects room IDs during tests and closes them all in the after block. Using Set to handle duplicate IDs gracefully, and .catch(() => {}) to prevent cleanup failures from blocking other tests.

Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>

codecov · 2026-03-03T15:03:36Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.47%. Comparing base (84754bb) to head (e4abb2f).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #39289      +/-   ##
===========================================
+ Coverage    70.14%   70.47%   +0.32%     
===========================================
  Files         3273     3263      -10     
  Lines       116240   116425     +185     
  Branches     20806    21000     +194     
===========================================
+ Hits         81538    82051     +513     
- Misses       31399    32342     +943     
+ Partials      3303     2032    -1271

Flag	Coverage Δ
unit	`70.93% <ø> (-0.06%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ggazzo · 2026-03-03T16:58:36Z

/jira ARCH-1464

cubic-dev-ai

No issues found across 1 file

Initial plan

97329f3

Copilot AI assigned Copilot and ggazzo Mar 3, 2026

Copilot started work on behalf of ggazzo March 3, 2026 14:00 View session

Copilot AI and others added 2 commits March 3, 2026 14:07

refactor: move visitor creation to before/after blocks in livechat ro…

4149bc9

…om tests Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>

refactor: split room tests into separate describe blocks for better i…

05d8622

…solation Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>

ggazzo requested changes Mar 3, 2026

View reviewed changes

Copilot AI changed the title ~~[WIP] Create visitor in before block and delete in after block~~ refactor: move visitor creation to before/after blocks in livechat room tests Mar 3, 2026

Copilot finished work on behalf of ggazzo March 3, 2026 14:11

Copilot started work on behalf of ggazzo March 3, 2026 14:11 View session

refactor: consolidate visitor before/after blocks into single shared …

9881835

…block Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>

Copilot finished work on behalf of ggazzo March 3, 2026 14:14

ggazzo requested changes Mar 3, 2026

View reviewed changes

Copilot started work on behalf of ggazzo March 3, 2026 14:22 View session

Copilot AI and others added 2 commits March 3, 2026 14:23

refactor: add room cleanup array to prevent after block failures

40804cb

Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>

refactor: use Set for room cleanup to handle duplicates gracefully

7a88808

Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>

Copilot finished work on behalf of ggazzo March 3, 2026 14:25

ggazzo reviewed Mar 3, 2026

View reviewed changes

Comment thread apps/meteor/tests/end-to-end/api/livechat/00-rooms.ts Outdated

Copilot started work on behalf of ggazzo March 3, 2026 14:28 View session

ggazzo reviewed Mar 3, 2026

View reviewed changes

Comment thread apps/meteor/tests/end-to-end/api/livechat/00-rooms.ts Outdated

refactor: move roomsToClose.add before expect statements

b3ca98f

Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>

Copilot finished work on behalf of ggazzo March 3, 2026 14:30

Copilot started work on behalf of ggazzo March 3, 2026 14:30 View session

refactor: remove room IDs from set after closing

2314cab

Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>

Copilot finished work on behalf of ggazzo March 3, 2026 14:32

ggazzo reviewed Mar 3, 2026

View reviewed changes

Comment thread apps/meteor/tests/end-to-end/api/livechat/00-rooms.ts Outdated

Apply suggestion from @ggazzo

9cd26ad

ggazzo added this to the 8.3.0 milestone Mar 3, 2026

ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Mar 3, 2026

ggazzo marked this pull request as ready for review March 3, 2026 16:58

ggazzo requested a review from a team as a code owner March 3, 2026 16:58

dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 3, 2026

dionisio-bot Bot enabled auto-merge March 3, 2026 16:58

ggazzo approved these changes Mar 3, 2026

View reviewed changes

KevLehman previously approved these changes Mar 3, 2026

View reviewed changes

cubic-dev-ai Bot reviewed Mar 3, 2026

View reviewed changes

lint

fd4dcc1

ggazzo dismissed KevLehman’s stale review via fd4dcc1 March 3, 2026 17:24

KevLehman approved these changes Mar 3, 2026

View reviewed changes

ggazzo modified the milestones: 8.3.0, 8.4.0 Apr 6, 2026

dionisio-bot Bot added community and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 6, 2026

ggazzo added 2 commits April 8, 2026 11:15

Merge branch 'develop' into copilot/create-visitor-in-before-block

86f1469

Merge branch 'develop' into copilot/create-visitor-in-before-block

e4abb2f

ggazzo modified the milestones: 8.4.0, 8.5.0 Apr 17, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: move visitor creation to before/after blocks in livechat room tests#39289

refactor: move visitor creation to before/after blocks in livechat room tests#39289
Copilot wants to merge 12 commits into
developfrom
copilot/create-visitor-in-before-block

Copilot AI commented Mar 3, 2026 •

edited

Loading

Uh oh!

dionisio-bot Bot commented Mar 3, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Mar 3, 2026 •

edited

Loading

Uh oh!

ggazzo left a comment

Uh oh!

Copilot AI commented Mar 3, 2026

Uh oh!

ggazzo left a comment

Uh oh!

Copilot AI commented Mar 3, 2026

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Mar 3, 2026 •

edited

Loading

Uh oh!

Uh oh!

ggazzo commented Mar 3, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comments on the Issue (you are @copilot in this section)

Uh oh!

dionisio-bot Bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

ggazzo left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Mar 3, 2026

Uh oh!

ggazzo left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Mar 3, 2026

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

ggazzo commented Mar 3, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 3, 2026 •

edited

Loading

dionisio-bot Bot commented Mar 3, 2026 •

edited

Loading

changeset-bot Bot commented Mar 3, 2026 •

edited

Loading

codecov Bot commented Mar 3, 2026 •

edited

Loading